chore: migrate to Node 24 and fix TypeScript catch variable typing#1297
Merged
Spiral-Memory merged 1 commit intoMay 18, 2026
Merged
Conversation
- Update .nvmrc to v24.0.0 - Update all GitHub Actions workflows to node-version 24 - Update packages/docs engines to >=24.0.0 - Fix TS2339 in EmbeddedChatApi.ts: use instanceof Error for catch variables - Bump Storybook deps to ^8.6.18 in react and ui-elements packages - Fix arrow-body-style lint error in EmbeddedChat.js - Improve EmbeddedChat re-instantiation logic with rcInstanceRef and state clearing
Spiral-Memory
approved these changes
May 18, 2026
Collaborator
|
LGTM! Thanks @Aryan-Verma-999 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to Node.js 24 and fix TypeScript catch variable typing
Acceptance Criteria fulfillment
.nvmrcand all GitHub Actions workflows (build-and-lint,build-pr,deploy,playwright) from Node 22 to Node 24packages/docs/package.jsonengine requirement to>=24.0.0TS2339: Property 'message' does not exist on type '{}'build errors inEmbeddedChatApi.tsreplaced unsafeerr?.messagewith propererr instanceof Error ? err.message : errtype narrowing across 28 catch blocks^8.0.0to^8.6.18inpackages/reactandpackages/ui-elementsfor React 19 compatibilityEmbeddedChatre-instantiation logic usercInstanceRefto prevent stale closures and clear global auth/message state on host/room changeVideo/Screenshots
N/A — infrastructure/build changes only, no visual UI changes.
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1297 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.